Skip to content

apps/ui: Unify url usage - #4282

Merged
nightnei merged 2 commits into
trunkfrom
unifyUrlUsage
Jul 21, 2026
Merged

apps/ui: Unify url usage#4282
nightnei merged 2 commits into
trunkfrom
unifyUrlUsage

Conversation

@nightnei

@nightnei nightnei commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

How AI was used in this PR

AI assisted

Proposed Changes

Let's clean up URLs usage in apps/ui

Testing Instructions

Visual review shoudl suffice, but JIC:

  1. npm run cli:build && npm start
  2. Electron -> Feature flags -> Enable agentic UI
  3. Click on Documentation and Report an issue
    Screenshot 2026-07-21 at 16 38 40
  4. Assert that you are landed on the correct URLs
  5. Switch language to Spanish
  6. Click again and assert that Documentation leads to the Spanish version
  7. Open Studio Settings and repeat the same steps with these two buttons:
    Screenshot 2026-07-21 at 16 41 15
  8. Open drop down menu here -> Click on Publish -> Click on Create a new wordpress.com site... and assert taht you are landed to https://wordpress.com/setup/new-hosted-site/domains.....
    Screenshot 2026-07-21 at 16 43 19
    8 Repeat the 8-th step via browser:
npm run cli:build
node apps/cli/dist/cli/main.mjs ui --port 8081 --no-open
npm run dev:local --workspace=apps/ui
# Open http://localhost:5400
@nightnei
nightnei requested review from bcotrim and sejas July 21, 2026 15:47
Base automatically changed from agentic-settings-account-section to trunk July 21, 2026 16:13
Comment thread apps/ui/src/data/core/connectors/publish-checkout-url.ts Outdated

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Approving so we can merge once we address the studio1 comment, or confirm it is intentional

@nightnei
nightnei enabled auto-merge (squash) July 21, 2026 16:45
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing f0ae4c7 vs trunk

app-size

Metric trunk f0ae4c7 Diff Change
App Size (Mac) 1361.88 MB 1361.88 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk f0ae4c7 Diff Change
load 1082 ms 1112 ms +30 ms ⚪ 0.0%

site-startup

Metric trunk f0ae4c7 Diff Change
siteCreation 7029 ms 6999 ms 30 ms ⚪ 0.0%
siteStartup 2355 ms 2364 ms +9 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@nightnei
nightnei merged commit 560cfa3 into trunk Jul 21, 2026
13 checks passed
@nightnei
nightnei deleted the unifyUrlUsage branch July 21, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants