Agentic UI: Render application settings as a fullscreen overlay - #4297
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing b07e4e8 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
…lscreen-overlay # Conflicts: # apps/ui/src/components/settings-view/index.tsx
…lscreen-overlay # Conflicts: # apps/ui/src/components/settings-view/index.test.tsx
sejas
approved these changes
Jul 22, 2026
Comment on lines
+26
to
+35
| export function FullscreenChrome( { onClose, closeLabel, closeDisabled }: FullscreenChromeProps ) { | ||
| return ( | ||
| <> | ||
| <div aria-hidden="true"> | ||
| <div className={ `${ styles.dragEdge } ${ styles.dragEdgeTop }` } /> | ||
| <div className={ `${ styles.dragEdge } ${ styles.dragEdgeLeft }` } /> | ||
| <div className={ `${ styles.dragEdge } ${ styles.dragEdgeBottom }` } /> | ||
| </div> | ||
| { onClose && ( | ||
| <IconButton |
Member
There was a problem hiding this comment.
This new component is similar to onboarding-layout. We can consider unifying them, or using this new one in the Onboarding layout.
studio/apps/ui/src/components/onboarding-layout/index.tsx
Lines 21 to 37 in 9eb8968
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issues
How AI was used in this PR
Implemented with Claude Code (ported the settings layout from the
explore-site-centric-conversation-chromedesign-preview branch, adapted to trunk, and wrote the tests); reviewed and visually verified manually.Proposed Changes
Per the settings design post, application settings now render full-screen, obscuring the workbench, instead of appearing inside the dashboard next to the sidebar.
/settings?tab=…) keep working unchanged.Testing Instructions
/settings(or navigate there directly) — settings renders, and closing lands on the home route.Pre-merge Checklist