Skip to content

Agentic UI: fix resizer for chat input - #4301

Merged
nightnei merged 2 commits into
trunkfrom
stu-2062-weird-border-on-chat-input-focus
Jul 23, 2026
Merged

Agentic UI: fix resizer for chat input#4301
nightnei merged 2 commits into
trunkfrom
stu-2062-weird-border-on-chat-input-focus

Conversation

@nightnei

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

AI assisted

Proposed Changes

  1. Electron -> Beta features -> Enable Agentic UI
  2. Mouse over at the top chat input border and assert that you see a draggable line, with styles aligned with teh left sidebar resizer:
    Screenshot 2026-07-22 at 13 43 25
  3. Click anywhere in the UI to focus teh window and then click tab button a few times to reach the chat input resizer
BEFORE AFTER
Screenshot 2026-07-22 at 13 44 27 Screenshot 2026-07-22 at 13 43 38
4. Click up/down buttons on your keyboard and assert that resizing works from the keyboard when the resizer is focused
@nightnei
nightnei requested review from bcotrim and sejas July 22, 2026 12:49
@nightnei nightnei self-assigned this Jul 22, 2026
@wpmobilebot

wpmobilebot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing b01b688 vs trunk

app-size

Metric trunk b01b688 Diff Change
App Size (Mac) 1362.03 MB 1361.91 MB 0.12 MB ⚪ 0.0%

site-editor

Metric trunk b01b688 Diff Change
load 1077 ms 1066 ms 11 ms ⚪ 0.0%

site-startup

Metric trunk b01b688 Diff Change
siteCreation 6969 ms 6982 ms +13 ms ⚪ 0.0%
siteStartup 2350 ms 2350 ms 0 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.shell:focus-within:not(:has(.resizeHandle:focus-visible)) {

Adding this prevents the double line.
What do you think?

Light Dark
Image Image

@sejas sejas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The selected top border looks better. I wonder if we can improve it a bit more around the borders but I think it's a minor thing and now it's much better. Thanks!

Before After
Image Image
@nightnei
nightnei enabled auto-merge (squash) July 23, 2026 10:42
@nightnei
nightnei merged commit 12d266b into trunk Jul 23, 2026
13 checks passed
@nightnei
nightnei deleted the stu-2062-weird-border-on-chat-input-focus branch July 23, 2026 11:42
@shaunandrews

Copy link
Copy Markdown
Contributor

the weird focus border was a genuine issue; but I avoided having a separate drag handle for the top border, mostly to avoid competing with the focus outline. In this case I felt it find to rely on the cursor changing on hover as a way to discover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants