Restrict local imports to registered uploads - #4308
Merged
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing ce4a1c3 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
nightnei
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issues
How AI was used in this PR
Codex helped inspect the CodeQL taint flow, implement the upload registry, and run automated verification. I reviewed the diff and manually confirmed that fabricated upload paths are rejected.
Proposed Changes
Testing Instructions
Build the CLI and start the local API server from this branch:
In another terminal, get the ID of an existing Studio site:
Submit an import request with a fabricated upload path:
Confirm the response is
HTTP/1.1 400 Bad Requestwith:{"error":"Unknown backup path"}Start the local web UI with
npm run dev:local --workspace=apps/ui, open http://localhost:5400, import a backup through Add site → Import from a backup, and confirm the normal import flow still completes.Pre-merge Checklist