Bump seroval to 1.5.6 to resolve fromJSON type confusion alert #299 - #4383
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
📊 Performance Test ResultsComparing 436e0b1 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code inspected the open Dependabot alerts, traced
serovalthrough the dependency tree (transitive via@tanstack/react-router), confirmed a cleannpm updateresolution with no other subtree churn, and verified every resolved copy landed on the patched version. I reviewed the lockfile diff myself.Proposed Changes
Resolves the critical
serovaladvisory (seroval.fromJSON()Promise resolver type confusion, which could invoke attacker-controlled methods during deserialization) by bumpingserovalfrom 1.5.2 to 1.5.6. This is a lockfile-only change to a transitive dependency; there is no user-visible behavior change.Testing Instructions
npm ciresolves cleanly.npm ls serovalreports 1.5.6 for every copy (no lingering 1.5.2).Pre-merge Checklist