Bump @modelcontextprotocol/sdk to 1.30.0 to resolve @hono/node-server path traversal alert #295 - #4384
Merged
Merged
Conversation
… path traversal alert #295 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
📊 Performance Test ResultsComparing eb25c28 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code traced
@hono/node-serverthrough the tree (transitive, pulled only by@modelcontextprotocol/sdkin the data-liberation-agent package), determined that the SDK's older pin (^1.19.9) couldn't reach a patched hono, and found that SDK 1.30.0 widened its range to^1.19.9 || ^2.0.5. It bumped the SDK pin so npm could dedup hono up to the patched 2.0.12, verified no direct-dependency pollution or override was needed, rebuilt the checked-in MCP bundle, and confirmed the package builds and that the only failing tests are pre-existing browser-fixture failures identical on trunk. I reviewed the diff myself.Proposed Changes
Resolves the
@hono/node-serverpath-traversal advisory (encoded-backslash%5Cdirectory escape inserve-staticon Windows), which reached the tree transitively through the data-liberation-agent's MCP SDK dependency. Bumping@modelcontextprotocol/sdkfrom 1.29.0 to 1.30.0 lets the resolver move@hono/node-serverto 2.0.12 — which also clears a second, newer advisory (unauthenticated WebSocket-handshake memory-leak DoS) that affects hono ≤2.0.9. The checked-in MCP bundle is rebuilt to match, consistent with prior dependency-bump PRs.No user-visible behavior change. The data-liberation-agent package targets Node ≥22, well above hono 2.x's Node 18.14.1 minimum, so the major bump carries no engine impact.
Testing Instructions
npm ciresolves cleanly.npm ls @hono/node-serverreports a single copy at 2.0.12 (no lingering 1.19.x, and hono is not added as a direct dependency).npm run build -w data-liberationsucceeds and regeneratesdist/mcp-server.bundle.mjs.npm auditreports no@hono/node-serverfindings.Pre-merge Checklist