Skip to content

Update model switch dialog copy in the agentic UI - #4391

Merged
shaunandrews merged 7 commits into
trunkfrom
stu-2167-update-model-switch-dialog-copy-in-the-agentic-ui
Jul 31, 2026
Merged

Update model switch dialog copy in the agentic UI#4391
shaunandrews merged 7 commits into
trunkfrom
stu-2167-update-model-switch-dialog-copy-in-the-agentic-ui

Conversation

@shaunandrews

@shaunandrews shaunandrews commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

How AI was used in this PR

AI located the model-switch confirmation flow, updated the user-facing copy, added regression coverage, and ran the required validation. The resulting diff was reviewed for scope and correctness.

Proposed Changes

image
  • Clarify that switching models starts a fresh chat while previous chats remain available from the Chat history button below the chat box. This replaces the incorrect sidebar reference and reassures users that their previous chats were not lost.

Testing Instructions

  1. Open an existing agentic UI conversation.
  2. Switch to a model in a different family, such as GPT 5.6 Sol.
  3. Confirm the dialog title reads “Start a new chat?”
  4. Confirm the dialog explains that previous chats are available from the Chat history button below the chat box and does not mention a sidebar.
  5. Confirm that starting the new conversation still switches to the selected model.

Automated validation:

  • npx eslint --fix apps/ui/src/ui-classic/components/session-view/composer/family-switch-confirm-dialog.tsx apps/ui/src/ui-classic/components/session-view/composer/index.test.tsx
  • npm run typecheck
  • npm test -- apps/ui/src/ui-classic/components/session-view/composer/index.test.tsx (11 tests passed)

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@shaunandrews
shaunandrews marked this pull request as ready for review July 29, 2026 19:04
@shaunandrews
shaunandrews requested review from a team and bcotrim July 29, 2026 19:04
@wpmobilebot

wpmobilebot commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 1611745 vs trunk

app-size

Metric trunk 1611745 Diff Change
App Size (Mac) 1378.88 MB 1378.88 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 1611745 Diff Change
load 1129 ms 1113 ms 16 ms ⚪ 0.0%

site-startup

Metric trunk 1611745 Diff Change
siteCreation 6518 ms 6524 ms +6 ms ⚪ 0.0%
siteStartup 2395 ms 2388 ms 7 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the button be "start a new chat?" instead of "conversation"?

Image
@shaunandrews

Copy link
Copy Markdown
Contributor Author

doh, yes! I'll fix.

@shaunandrews

Copy link
Copy Markdown
Contributor Author

Wait @copilot can you fix the button label for me?

Copilot AI commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Wait @copilot can you fix the button label for me?

Done — the button now reads "Start a new chat" to match the dialog title. Updated the test to match as well.

@shaunandrews

Copy link
Copy Markdown
Contributor Author

Meh @copilot I'm not loving it. I think the button label should answer the question in the heading. So maybe:

Start a new chat?

Switching from Opus 5 to GPT 5.6 Sol starts a fresh chat
because the models don’t share memory. You can find
previous chats using Chat history below the chat box.

                              [ Cancel ] [ Yes, new chat ]

--

I updated the paragraph of text too, to be a little shorter. Anything you can do to avoid the orphaned word? Maybe the shorter text alone does it. Any chance you can spin up the app in the cloud and take a screenshot when you're done, then include it in your reponse.

Copilot AI commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Meh @copilot I'm not loving it. I think the button label should answer the question in the heading. So maybe:

Start a new chat?
...

Done — button is now "Yes, new chat" and the body copy is updated to the shorter form. As for a screenshot, I'm not able to spin up the app in this sandbox environment, so that'll need a human visual check.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@shaunandrews

Copy link
Copy Markdown
Contributor Author

Copilot did ok, but I ended up having to jump in myself.

image

I added the pretty CSS, and double-checked the modal. 👍

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Light Dark
Image Image

@nightnei nightnei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Screenshot 2026-07-31 at 11 49 44
Screenshot 2026-07-31 at 11 50 20

@shaunandrews
shaunandrews merged commit 230b401 into trunk Jul 31, 2026
14 checks passed
@shaunandrews
shaunandrews deleted the stu-2167-update-model-switch-dialog-copy-in-the-agentic-ui branch July 31, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants