Skip to content

fix: Catch failed demo site status check errors - #44

Merged
dcalhoun merged 2 commits into
trunkfrom
fix/catch-failed-demo-site-status-check-errors
Apr 29, 2024
Merged

fix: Catch failed demo site status check errors#44
dcalhoun merged 2 commits into
trunkfrom
fix/catch-failed-demo-site-status-check-errors

Conversation

@dcalhoun

@dcalhoun dcalhoun commented Apr 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes https://github.com/Automattic/dotcom-forge/issues/6699.

Proposed Changes

Ensure demo site status check failures do not result in crashes.

Testing Instructions

  1. Create a site.
  2. Create a demo site for the site.
  3. Delete the demo site.
  4. While the deletion request is ongoing, disable your internet connection.
  5. Verify the app does not crash.
  6. Re-enable your internet connection.
  7. Verify the demo site is successfully deleted and the UI is updated accordingly.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@dcalhoun dcalhoun added the bug label Apr 26, 2024
@dcalhoun dcalhoun self-assigned this Apr 26, 2024
dcalhoun added 2 commits April 26, 2024 14:22
@dcalhoun
fix: Catch failed demo site status check errors
a32e793 
Ensure demo site status check failures do not result in crashes.
@dcalhoun
fix: Prevent unnecessary demo site status request while offline
0dad90e 
These requests will always fail, producing unnecessary noise.
@dcalhoun
dcalhoun force-pushed the fix/catch-failed-demo-site-status-check-errors branch from a6f31bf to 0dad90e Compare April 26, 2024 18:34
@dcalhoun
dcalhoun marked this pull request as ready for review April 26, 2024 18:44
@dcalhoun
dcalhoun requested a review from a team April 26, 2024 18:44
@derekblank
derekblank self-requested a review April 29, 2024 04:14
derekblank
derekblank approved these changes Apr 29, 2024
View reviewed changes

@derekblank derekblank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was able to follow the testing instructions successfully and did not note any issues. 🚀
@dcalhoun

dcalhoun commented Apr 29, 2024

Copy link
Copy Markdown
Member Author

Merging with the current approval, but others should please feel free to provide additional feedback and I will follow up as needed.
@dcalhoun
dcalhoun merged commit a86130d into trunk Apr 29, 2024
@dcalhoun
dcalhoun deleted the fix/catch-failed-demo-site-status-check-errors branch April 29, 2024 13:24
@wojtekn wojtekn mentioned this pull request Jun 3, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@dcalhoun @derekblank