Agentic UI: Don't start a site while a stop for it is still in flight - #4406
Draft
bcotrim wants to merge 1 commit into
Draft
Agentic UI: Don't start a site while a stop for it is still in flight#4406bcotrim wants to merge 1 commit into
bcotrim wants to merge 1 commit into
Conversation
Collaborator
📊 Performance Test ResultsComparing a57383e vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
bcotrim
marked this pull request as draft
July 31, 2026 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code traced the race and wrote the fix and tests. I found the repro (pressing a destination while a site is stopping) and reviewed the diff.
Proposed Changes
Starting a site while a stop for it is still in flight leaves the site down — the stop lands last — while the UI believes it started. Every "not running, so start it" path then tries again, and it loops; the site never comes up.
The guard goes in
useStartSiterather than at any one call site, so it holds for all of them: the sidebar, the site dropdown, the preview's Start button, auto-start on launch, and anything opening a URL in the preview. A skipped start no longer shows the "Site started" toast.Testing Instructions
Starting server for '<site>'in the terminal).Pre-merge Checklist
🤖 Generated with Claude Code