Skip to content

Add badge to readme with crash free session rate - #441

Merged
fluiddot merged 4 commits into
trunkfrom
add/readme-crash-free-badge
Aug 8, 2024
Merged

Add badge to readme with crash free session rate#441
fluiddot merged 4 commits into
trunkfrom
add/readme-crash-free-badge

Conversation

@fluiddot

@fluiddot fluiddot commented Aug 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related to p1723038652725999/1723037385.951859-slack-C06DRMD6VPZ.

Proposed Changes

  • Add badge to README with static value of current Crash Free Session rate.

Testing Instructions

  • Display the rich diff for the README file and observe that the badge is displayed.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@fluiddot
fluiddot requested a review from a team August 8, 2024 10:20
@fluiddot fluiddot self-assigned this Aug 8, 2024
wojtekn
wojtekn reviewed Aug 8, 2024
View reviewed changes
Comment thread README.md Outdated
@@ -1,3 +1,5 @@
[![Crash Free Sessions Rate](https://img.shields.io/badge/Crash_Free_Session_Rate-91.631%25-blue)](https://a8c.sentry.io/projects/studio/?project=4506612776501248&statsPeriod=7d)

@wojtekn wojtekn Aug 8, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be 93.623% as for now? What value do we exactly use?

@fluiddot fluiddot Aug 8, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value I'm using is the one for the last seven days for all versions. I.e. the same shown when clicking on the badge. It's true it changed since when I created the PR, the latest value is: 92.02%. I'll update it asap.

Alternatively, we could us the rate from the latest version. WDYT?

@wojtekn wojtekn Aug 8, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay as it is now, thanks.
katinthehatsite
katinthehatsite reviewed Aug 8, 2024
View reviewed changes

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good!

If someone does not have a Sentry account, should they still be able to see the Sentry link?
@fluiddot

fluiddot commented Aug 8, 2024

Copy link
Copy Markdown
Contributor Author

If someone does not have a Sentry account, should they still be able to see the Sentry link?

Good question. I assumed the project would be accessible publicly but seems only public URLs can be generated for issues. Since only team members have access, I'll remove the link. Thanks for the call out 🙇 !
@fluiddot
fluiddot merged commit 122e941 into trunk Aug 8, 2024
@fluiddot
fluiddot deleted the add/readme-crash-free-badge branch August 8, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@fluiddot @wojtekn @katinthehatsite