Clean up space limit constants and increase it to 250 MB - #446
Merged
Conversation
kozer
approved these changes
Aug 12, 2024
kozer
left a comment
kozer
left a comment
Contributor
There was a problem hiding this comment.
Tested it and works as expected! Nice work Wojtek!
sejas
approved these changes
Aug 13, 2024
sejas
left a comment
sejas
left a comment
Member
There was a problem hiding this comment.
Looks good! Thanks for increasing the snapshots size. I confirm the alert appears when the wp-content zip file is bigger than 250MB and it works if its smaller.
I've added a suggestion about removing Math.floor.
TeMPT1.mp4
| 'The site exceeds the maximum size of %dMB. Please remove some files and try again.' | ||
| ), | ||
| Math.floor( LIMIT_ARCHIVE_SIZE / 1024 / 1024 ) | ||
| Math.floor( SIZE_LIMIT_MB ) |
Member
There was a problem hiding this comment.
Should we remove the Math.floor ?
Suggested change
| Math.floor( SIZE_LIMIT_MB ) | |
| SIZE_LIMIT_MB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/Automattic/dotcom-forge/issues/8515
Proposed Changes
I propose increasing the demo size limit to 250 MB and cleaning up constants to avoid calculating values twice.
Testing Instructions
Happy path
Error
Pre-merge Checklist