Skip to content

Ensure all strings are updated when switching language #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kozer merged 6 commits into from
Sep 3, 2024
Merged

Ensure all strings are updated when switching language #504

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09327cc
Update default I18n locate data when switching language
fluiddot Sep 3, 2024
8849474
Update default I18n locate data in main process
fluiddot Sep 3, 2024
c0743f4
Delegate app menu setup to `useI18nData` hook
fluiddot Sep 3, 2024
4b237a0
Reset default locale data when no translations are found
fluiddot Sep 3, 2024
21ddf81
Update: Remove unecessary resetLocaleData
kozer Sep 3, 2024
f6378fd
Revert "Update: Remove unecessary resetLocaleData"
kozer Sep 3, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update default I18n locate data when switching language
  • Loading branch information
@fluiddot
fluiddot committed Sep 3, 2024
commit 09327cc220ea90dd15e9fc5fc2c3406a2d44fa1a
8 changes: 6 additions & 2 deletions src/hooks/use-i18n-data.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createI18n, I18n } from '@wordpress/i18n';
import { createI18n, I18n, defaultI18n } from '@wordpress/i18n';
import { I18nProvider } from '@wordpress/react-i18n';
import { createContext, useContext, useEffect, useMemo, useState, useCallback } from 'react';
import { getIpcApi } from '../lib/get-ipc-api';
Expand All @@ -21,8 +21,12 @@ export const I18nDataProvider = ( { children }: { children: React.ReactNode } )
const [ locale, setLocale ] = useState< SupportedLocale >( 'en' );

const initI18n = useCallback( async ( localeKey: SupportedLocale ) => {
const newI18n = createI18n( getLocaleData( localeKey )?.messages );
const translations = getLocaleData( localeKey )?.messages;
const newI18n = createI18n( translations );
setI18n( newI18n );
// Update default I18n data to reflect language change when using
// I18n functions from `@wordpress/i18n` package.
defaultI18n.setLocaleData( translations );
}, [] );

useEffect( () => {
Expand Down