Skip to content

i18n: Make aria-label text translatable - #53

Merged
SiobhyB merged 1 commit into
Automattic:trunkfrom
t-hamano:i18n/translate-aria-label
Apr 28, 2024
Merged

i18n: Make aria-label text translatable#53
SiobhyB merged 1 commit into
Automattic:trunkfrom
t-hamano:i18n/translate-aria-label

Conversation

@t-hamano

@t-hamano t-hamano commented Apr 28, 2024

Copy link
Copy Markdown
Contributor

Proposed Changes

I noticed that the text in the following three places is not translatable.

Global

global

Offline Indicator

offline-indicator

Sites

sites

Testing Instructions

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@SiobhyB
SiobhyB self-requested a review April 28, 2024 06:34

@SiobhyB SiobhyB left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting and fixing these @t-hamano! 🙌

@SiobhyB
SiobhyB merged commit be4c50e into Automattic:trunk Apr 28, 2024
@t-hamano
t-hamano deleted the i18n/translate-aria-label branch April 30, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants