Update playground to version 0.9.44

[jeroenpf]

Proposed Changes

• Update Playground from 0.9.39 to version 0.9.44
• This update contains various improvements including MySQL compatibility fixes

Testing Instructions

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[fluiddot]

For reference, here are the changes introduced in Playground:
WordPress/wordpress-playground@v0.9.39...v0.9.44

[fluiddot]

LGTM 🎊 !

I've tested a site using MySQL and I didn't find any crash as outlined in #358 🎊 !

[wojtekn]

Looks good. Thanks for fixing this in the upstream @jeroenpf (WordPress/wordpress-playground#1752) and upgrading Playground in Studio!

[wojtekn]

I've tested it more, but it seems that when I try to start the site configured to use MySQL, it crashes:

node:internal/errors:497
    ErrorCaptureStackTrace(err);
    ^

TypeError [ERR_HTTP_INVALID_HEADER_VALUE]: Invalid value "undefined" for header "set-cookie"
    at ServerResponse.setHeader (node:_http_outgoing:655:3)
    at /Volumes/Sites/local-environment/.webpack/main/siteServerProcess.js:61899:21
    at Generator.next (<anonymous>)
    at fulfilled (/Volumes/Sites/local-environment/.webpack/main/siteServerProcess.js:61839:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 'ERR_HTTP_INVALID_HEADER_VALUE'
}

Node.js v20.9.0

When I use Studio 1.1.2, it works fine.

[wojtekn]

Also, it seems that the above crash happens when I'm using MySQL, but with incorrect credentials configured in wp-config.php. When I use the correct credentials, I see a broken site:

When I use Studio 1.1.2, both cases work: incorrect credentials show the page informing me about the problems connecting to MySQL, and correct credentials show the correct site.

[fluiddot]

I've tested it more, but it seems that when I try to start the site configured to use MySQL, it crashes:

node:internal/errors:497
    ErrorCaptureStackTrace(err);
    ^

TypeError [ERR_HTTP_INVALID_HEADER_VALUE]: Invalid value "undefined" for header "set-cookie"
    at ServerResponse.setHeader (node:_http_outgoing:655:3)
    at /Volumes/Sites/local-environment/.webpack/main/siteServerProcess.js:61899:21
    at Generator.next (<anonymous>)
    at fulfilled (/Volumes/Sites/local-environment/.webpack/main/siteServerProcess.js:61839:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 'ERR_HTTP_INVALID_HEADER_VALUE'
}

Node.js v20.9.0

When I use Studio 1.1.2, it works fine.

@wojtekn how did you reproduce it?

Based on the error message, I wonder if it's related to #532 🤔 .

[wojtekn]

@wojtekn how did you reproduce it?

Here are the steps:

1. Start Studio in dev mode from this branch
2. Add a site and open it in IDE
3. Remove wp-content/database/, mu-plugins/sqlite-database-integration and wp-content/db.php.
4. Open WP Admin

Expected behavior: the following page is served:

Current behavior: site crashes with set-cookie error

[fluiddot]

@wojtekn how did you reproduce it?

Here are the steps:

1. Start Studio in dev mode from this branch
2. Add a site and open it in IDE
3. Remove wp-content/database/, mu-plugins/sqlite-database-integration and wp-content/db.php.
4. Open WP Admin

Expected behavior: the following page is served:

Current behavior: site crashes with set-cookie error

Ah, good catch. As I shared in #561 (comment), this is a bug most likely introduced in #532. I've pushed a fix in 0f0d45e.

Now when accessing WP-Admin in the scenario shared in #561 (comment), it shows the error page:

[wojtekn]

Thanks @fluiddot , works well now.

[fluiddot]

I encountered a weird behavior when testing a site with MySQL files inside the site's folder, specifically when having the symlink mysql.sock. I presume this is an edge case, as users won't have these files in the site's folder, however, this uncovers a bug related to not-resolvable symlinks and the site initialization. I'll open a separate GitHub issue as it's not related to this PR.

UPDATE: Here's the issue 9257-gh-Automattic/dotcom-forge.

[jeroenpf]

Is this still good for a merge?

[fluiddot]

Is this still good for a merge?

Yes, from my side it's ready to be merged .

[fluiddot]

I noticed that the patch introduced in #532 is no longer being applied is giving a warning due to version mismatch but is still being applied after upgrading the Playground dependencies. I'll open a PR to update it.

UPDATE: Here's the PR #580.