Studio: Bubble up path validation error - #564
Merged
Merged
Conversation
wojtekn
approved these changes
Sep 27, 2024
wojtekn
left a comment
Contributor
There was a problem hiding this comment.
there is an error related to the Local path address
AND the Advanced settings tab is closed
This description could suggest that the error is relayed only if those two conditions are true, but based on my tests, I see it is relayed also when Advanced settings are open. However, I think it's even better that way.
Contributor
Author
Thanks @wojtekn - yeah this was the original intention and it is the description that failed me 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Automattic/dotcom-forge/issues/9069
Proposed Changes
This PR adds a new error indication to the add site form for the case when:
Local pathaddressAdvanced settingstab is closedTesting Instructions
nvm use && npm install && npm startMy WordPress Sitein StudioMy WordPress Site1 error foundand theAdvanced settingstext goes redAdvanced settingstext goes back to the usual colorRToz6tIuQ7nlZrikBte4GU-fi-3748_312092
Pre-merge Checklist