Skip to content

Fix broken symlinks prevents the site to be started #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fluiddot merged 3 commits into from
Sep 26, 2024
Merged

Fix broken symlinks prevents the site to be started #566

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a44dad4
Avoid exception when symlink can't be resolved
fluiddot Sep 26, 2024
f7a2906
Add unit test to cover broken symlinks case
fluiddot Sep 26, 2024
6e3ab2b
Merge branch 'trunk' into fix/broken-symlink-prevent-start-site
fluiddot Sep 26, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Avoid exception when symlink can't be resolved
  • Loading branch information
@fluiddot
fluiddot committed Sep 26, 2024
commit a44dad4737ff89fcffb45e99dba87e554bcc19a6
13 changes: 12 additions & 1 deletion src/lib/symlink-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import path from 'path';
import { createNodeFsMountHandler } from '@php-wasm/node';
import { PHP, UnmountFunction } from '@php-wasm/universal';
import { pathExists } from './fs-utils';
import { isErrnoException } from './is-errno-exception';

type MountedTarget = {
preExisting: boolean;
Expand Down Expand Up @@ -137,7 +138,17 @@ export class SymlinkManager {
*/
private async addSymlink( filename: string ) {
const fullPath = path.join( this.projectPath, filename );
const target = await fs.realpath( fullPath );
let target: string;
try {
target = await fs.realpath( fullPath );
} catch ( err ) {
if ( isErrnoException( err ) && err.code === 'ENOENT' ) {
console.error( `Symlink target does not exist: ${ fullPath }` );
return;
}
console.error( err );
return;
}

if ( ! this.php.requestHandler ) {
throw new Error( 'Request handler is not set' );
Expand Down