Change loading state label to 'Loading' to cover both start and stop

[wojtekn]

Related to https://github.com/Automattic/dotcom-forge/issues/9292

Proposed Changes

I propose to change the loading state label from 'Starting' to 'Loading' to cover both start and stop.

I considered splitting the 'loading' status into 'starting' and 'stopping', so we could display different labels each time, but it would make the code more complex and wouldn't provide value to the user, especially since stopping is quick in most cases.

I thought about using 'Processing', too, but 'Loading' seems clearer in this case.

Testing Instructions

1. Start and stop site
2. Confirm that new label shows 'Loading...'

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[katinthehatsite]

The changes look good to me. I think that it is not worth it to split the label for starting and stopping at this point since, as you mentioned, it would complicate the code quite a bit and the stopping part is not even that noticeable.

[sejas]

Looks good to me.
If we prefer displaying two different labels, then we can do it without increasing the complexity of the code.
See my comment below.

Approving, since It's not a strong opinion and Loading is a good solution, but probably keeping two different labels is a better solution.
One way to delay the process of stopping is just opening a new window in Playground before clicking Stop.

Uv2Y4g.mp4

[sejas]

What do you think about displaying different labels?

Suggested change

	buttonLabel = __( 'Loading…' );
	buttonLabel = isRunning ? __( 'Stopping…' ) : __( 'Starting…' );

jR31Fc.mp4

[wojtekn]

Thanks, makes sense. Changed: 5d72de8