Let user open Settings menu in offline mode - #582
Merged
Conversation
Contributor
|
Tested on macOS and works as expected. 👍 |
katinthehatsite
approved these changes
Oct 4, 2024
katinthehatsite
left a comment
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
The functionality worked as expected for me on macOS.
Nice work!
sejas
approved these changes
Oct 4, 2024
sejas
left a comment
sejas
left a comment
Member
There was a problem hiding this comment.
It works great! I tested it by clicking on the login and I see how the settings modal open.
If the app is offline, I see the login button inside the modal is disabled.
Thanks for fixing the tests.
S1GxBu.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/Automattic/dotcom-forge/issues/9298
Proposed Changes
Now, when the Settings menu allows selecting language, I propose letting users open it using the 'Log in' link in the top bar, making it consistent with behavior for a logged-in state.
Testing Instructions
Pre-merge Checklist