Skip to content

Regenerate media thumbnails when importing any WordPress backup #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sejas merged 8 commits into from
Oct 11, 2024
Merged

Regenerate media thumbnails when importing any WordPress backup #592

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8a724f8
Add afterImport optional method to run media regenerate for Jetpack b…
sejas Oct 10, 2024
dbb4241
add message for new import step to regenerate media
sejas Oct 10, 2024
c495803
add test to check media regenerate is executed correctly
sejas Oct 10, 2024
3d9fd67
update tests to reflect new progress
sejas Oct 10, 2024
1676e8d
add test to check the new message regenerate media import step is di…
sejas Oct 10, 2024
79f03bf
Run regenerate media for each import
sejas Oct 11, 2024
f0d8086
Merge branch 'trunk' of github.com:Automattic/studio into fix/jeptack…
sejas Oct 11, 2024
f9cc231
Make sure wp-config for new installations
sejas Oct 11, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run regenerate media for each import
  • Loading branch information
@sejas
sejas committed Oct 11, 2024
commit 79f03bf273ebe2ffe052f535cddeb4a344244af0
26 changes: 14 additions & 12 deletions src/lib/import-export/import/importers/importer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ abstract class BaseImporter extends EventEmitter implements Importer {
}

abstract class BaseBackupImporter extends BaseImporter {
protected async afterImport?( siteId: string ): Promise< void >;
async import( rootPath: string, siteId: string ): Promise< ImporterResult > {
this.emit( ImportEvents.IMPORT_START );

Expand All @@ -138,7 +137,7 @@ abstract class BaseBackupImporter extends BaseImporter {
this.meta = await this.parseMetaFile();
}
await this.importDatabase( rootPath, siteId, this.backup.sqlFiles );
await this.afterImport?.( siteId );
await this.regenerateMedia( siteId );

this.emit( ImportEvents.IMPORT_COMPLETE );
return {
Expand All @@ -157,6 +156,19 @@ abstract class BaseBackupImporter extends BaseImporter {

protected abstract parseMetaFile(): Promise< MetaFileData | undefined >;

protected async regenerateMedia( siteId: string ): Promise< void > {
const server = SiteServer.get( siteId );
if ( ! server ) {
throw new Error( 'Site not found.' );
}
this.emit( ImportEvents.IMPORT_MEDIA_REGENERATE_START );
const { stderr } = await server.executeWpCliCommand( 'media regenerate --yes' );
if ( stderr ) {
console.error( 'Error during media regeneration:', stderr );
}
this.emit( ImportEvents.IMPORT_MEDIA_REGENERATE_COMPLETE );
}

protected async createEmptyDatabase( dbPath: string ): Promise< void > {
await fsPromises.writeFile( dbPath, '' );
}
Expand Down Expand Up @@ -240,16 +252,6 @@ export class JetpackImporter extends BaseBackupImporter {
this.emit( ImportEvents.IMPORT_META_COMPLETE );
}
}

protected async afterImport( siteId: string ) {
const server = SiteServer.get( siteId );
if ( ! server ) {
throw new Error( 'Site not found.' );
}
this.emit( ImportEvents.IMPORT_MEDIA_REGENERATE_START );
await server.executeWpCliCommand( 'media regenerate --yes' );
this.emit( ImportEvents.IMPORT_MEDIA_REGENERATE_COMPLETE );
}
}

export class LocalImporter extends BaseBackupImporter {
Expand Down