Skip to content

Fix overflow issue for extremely long site name #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derekblank merged 2 commits into from
Apr 29, 2024
Merged

Fix overflow issue for extremely long site name #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b01625
Fix overflow issue for extremely long site name
derekblank Apr 29, 2024
c93f481
Fix linter style issue
derekblank Apr 29, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/content-tab-settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export function ContentTabSettings( { selectedSite }: ContentTabSettingsProps )
</tr>
<SettingsRow label={ __( 'Site name' ) }>
<div className="flex">
<span className="line-clamp-1">{ selectedSite.name }</span>
<span className="line-clamp-1 break-all">{ selectedSite.name }</span>
<EditSite />
</div>
</SettingsRow>
Expand All @@ -60,7 +60,7 @@ export function ContentTabSettings( { selectedSite }: ContentTabSettingsProps )
onClick={ () => getIpcApi().openLocalPath( selectedSite.path ) }
variant="link"
>
<span className="line-clamp-1">{ selectedSite.path }</span>
<span className="line-clamp-1 break-all">{ selectedSite.path }</span>
<Icon size={ 13 } icon={ file } className="shrink-0" />
</Button>
</SettingsRow>
Expand Down
4 changes: 3 additions & 1 deletion src/components/content-tab-snapshots.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ function SnapshotRow( {
return (
<div className="self-stretch flex-col px-4 py-3">
<div className="flex gap-2 items-center">
<div className="text-black a8c-subtitle-small demo-site-name">{ selectedSite.name }</div>
<div className="text-black a8c-subtitle-small demo-site-name line-clamp-1 break-all">
{ selectedSite.name }
</div>
<Badge>{ __( 'Demo site' ) }</Badge>
</div>
<CopyTextButton
Expand Down
2 changes: 1 addition & 1 deletion src/components/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function Header() {
>
{ site && (
<div className="flex flex-col">
<h1 className="text-xl font-normal max-h-full line-clamp-1">
<h1 className="text-xl font-normal max-h-full line-clamp-1 break-all">
{ site ? site.name : null }
</h1>
<div className="flex mt-1 gap-x-4">
Expand Down