Ensure Mac's titlebar padding always leaves space for the window controls - #603
Merged
Conversation
sejas
approved these changes
Oct 16, 2024
Member
Author
Yeah it'd be nice to boot the app with the correct switch given the user's setting I think. |
Contributor
|
Thanks for the fix @p-jackson ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Related to #541 and #596
This PR fixes the same issue as #596 except this time for Mac. Namely, the padding in the app's top bar needs to be aware of both the RTL mode of the language and the RTL mode of the underlying browser window.
Proposed Changes
isWindowFrameRtllogic into utility module<MacTitlebar>component that does the equivalent job of<WindowsTitlebar>@wordpress/i18netc.remtrunkto confirm none of the padding sidebar padding has changed.RTL language in a RTL window

LTR language in a RTL window

LTR language in a LTR window

RTL language in a LTR window

Testing Instructions
Here's a quick way to change the browser window's language without having to reboot your OS into a different language: add
app.commandLine.appendSwitch( 'lang', 'ar' );at the very top ofindex.ts, right after theimportstatements.Pre-merge Checklist