Fix hardcoded wp-cli execution paths - #606
Merged
Merged
Conversation
Contributor
I think it makes sense to at least document the issue separately so that we are aware that it exists. |
katinthehatsite
approved these changes
Oct 17, 2024
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
The changes look good to me 👍 Thanks for the fix!
There is a small typo in the command pm run make instead of npm run make in the testing steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to p1729153254575689-slack-C06DRMD6VPZ
Proposed Changes
In dev mode, when running
npm start, wp-cli in wasm is loaded correctly in the terminal, because it takes the path of the dev Electron + the path of the project and it considers that as a single command. It seems it didn't work before either. It was introduced on #268If we consider something important, we can create an issue to tackle it separately.
Testing Instructions
npm run make && STUDIO_TERMINAL_WP_CLI=true open out/Studio-darwin-arm64/Studio.app/Contents/MacOS/Studiowp --versionWP-CLI 2.11.0.Pre-merge Checklist