Studio: Update WordPress.com logo - #624
Merged
Merged
Conversation
Also made some minor adjustments to spacing and alignment in the header bar.
Co-authored-by: katinthehatsite <katerynakodonenko@gmail.com>
Co-authored-by: katinthehatsite <katerynakodonenko@gmail.com>
Contributor
Author
|
Thanks for catching that @katinthehatsite! I’ve applied your suggestions and tested locally to verify that the console warnings are gone. |
katinthehatsite
approved these changes
Oct 25, 2024
Contributor
|
Sounds good @matt-west - I approved the PR! |
Contributor
|
@matt-west the new logo looks better, thanks for the fix. I've just noticed a slight layout shift between logged-in and logged-out states: 
|
Contributor
Author
|
@wojtekn Good catch! I’ve removed the unnecessary vertical padding from the logo. This should fix the layout shift between logged in/out states.
|
Contributor
|
@matt-west looks great now! |
wojtekn
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #620
Proposed Changes
Testing Instructions
Pre-merge Checklist