Add mu-plugin that disables Jetpack Protect on the fly to enable auto-login - #658
Merged
Merged
Conversation
Contributor
|
@wojtekn I am not familiar with this process yet, could you please add more details for:
|
Contributor
Author
|
@nightnei I've updated steps with more details, as well as the issue description. |
katinthehatsite
approved these changes
Nov 15, 2024
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
The changes worked as expected for me 👍
I compared the login with the trunk and was able to auto-login on this branch while on trunk, I got an extra login screen.
nightnei
approved these changes
Nov 15, 2024
nightnei
left a comment
Contributor
There was a problem hiding this comment.
Works as expected - in trunk I got login screen, but in this branch I was automatically authorized 👍
Contributor
Author
|
Thanks for review @katinthehatsite and @nightnei . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
I propose adding an mu-plugin that deactivates Jetpack Protect on the fly to avoid showing math questions in the login form.
Before the change, it prevented users from using "WP Admin" auto-login on local sites that have Jetpack installed. When users used "WP Admin", it showed the login form with the math question:
The expected behavior is to get the user automatically logged in to WP Admin, regardless of whether Jetpack is installed.
Testing Instructions
Pre-merge Checklist