Skip to content

Address file permission issues in new directories created by WordPress on Windows #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fluiddot merged 2 commits into from
May 7, 2024
Merged

Address file permission issues in new directories created by WordPress on Windows #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db9afda
Patch PHP runtimes to avoid conflicts with file permissions on Windows
fluiddot Apr 29, 2024
5962959
Update PHP runtime path with simpler approach
fluiddot Apr 30, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions patches/@php-wasm+node+0.6.16.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
diff --git a/node_modules/@php-wasm/node/index.cjs b/node_modules/@php-wasm/node/index.cjs
index 1be4252..7f01cfd 100644
--- a/node_modules/@php-wasm/node/index.cjs
+++ b/node_modules/@php-wasm/node/index.cjs
@@ -6650,6 +6650,11 @@ function init(RuntimeName, PHPLoader) {
doStat: function(func, path, buf) {
try {
var stat = func(path);
+ if (NODEFS.isWindows) {
+ // Node.js on Windows never represents permission bit 'x', so
+ // propagate read bits to execute bits.
+ stat.mode = stat.mode | (stat.mode & 292) >> 2;
+ }
} catch (e) {
if (e && e.node && PATH.normalize(path) !== PATH.normalize(FS.getPath(e.node))) {
return -54;
@@ -14280,6 +14285,11 @@ function init2(RuntimeName, PHPLoader) {
doStat: function(func, path, buf) {
try {
var stat = func(path);
+ if (NODEFS.isWindows) {
+ // Node.js on Windows never represents permission bit 'x', so
+ // propagate read bits to execute bits.
+ stat.mode = stat.mode | (stat.mode & 292) >> 2;
+ }
} catch (e) {
if (e && e.node && PATH.normalize(path) !== PATH.normalize(FS.getPath(e.node))) {
return -54;
@@ -21910,6 +21920,11 @@ function init3(RuntimeName, PHPLoader) {
doStat: function(func, path, buf) {
try {
var stat = func(path);
+ if (NODEFS.isWindows) {
+ // Node.js on Windows never represents permission bit 'x', so
+ // propagate read bits to execute bits.
+ stat.mode = stat.mode | (stat.mode & 292) >> 2;
+ }
} catch (e) {
if (e && e.node && PATH.normalize(path) !== PATH.normalize(FS.getPath(e.node))) {
return -54;
@@ -29535,6 +29550,11 @@ function init4(RuntimeName, PHPLoader) {
doStat: function(func, path, buf) {
try {
var stat = func(path);
+ if (NODEFS.isWindows) {
+ // Node.js on Windows never represents permission bit 'x', so
+ // propagate read bits to execute bits.
+ stat.mode = stat.mode | (stat.mode & 292) >> 2;
+ }
} catch (e) {
if (e && e.node && PATH.normalize(path) !== PATH.normalize(FS.getPath(e.node))) {
return -54;
Comment on lines +41 to +52

@fluiddot fluiddot Apr 30, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This corresponds to PHP version 8.0, the one that is used by default in the Studio app.
@@ -37133,6 +37153,11 @@ function init5(RuntimeName, PHPLoader) {
doStat: function(func, path, buf) {
try {
var stat = func(path);
+ if (NODEFS.isWindows) {
+ // Node.js on Windows never represents permission bit 'x', so
+ // propagate read bits to execute bits.
+ stat.mode = stat.mode | (stat.mode & 292) >> 2;
+ }
} catch (e) {
if (e && e.node && PATH.normalize(path) !== PATH.normalize(FS.getPath(e.node))) {
return -54;
@@ -44716,6 +44741,11 @@ function init6(RuntimeName, PHPLoader) {
doStat: function(func, path, buf) {
try {
var stat = func(path);
+ if (NODEFS.isWindows) {
+ // Node.js on Windows never represents permission bit 'x', so
+ // propagate read bits to execute bits.
+ stat.mode = stat.mode | (stat.mode & 292) >> 2;
+ }
} catch (e) {
if (e && e.node && PATH.normalize(path) !== PATH.normalize(FS.getPath(e.node))) {
return -54;
@@ -52294,6 +52324,11 @@ function init7(RuntimeName, PHPLoader) {
doStat: function(func, path, buf) {
try {
var stat = func(path);
+ if (NODEFS.isWindows) {
+ // Node.js on Windows never represents permission bit 'x', so
+ // propagate read bits to execute bits.
+ stat.mode = stat.mode | (stat.mode & 292) >> 2;
+ }
} catch (e) {
if (e && e.node && PATH.normalize(path) !== PATH.normalize(FS.getPath(e.node))) {
return -54;
@@ -59740,6 +59775,11 @@ function init8(RuntimeName, PHPLoader) {
doStat: function(func, path, buf) {
try {
var stat = func(path);
+ if (NODEFS.isWindows) {
+ // Node.js on Windows never represents permission bit 'x', so
+ // propagate read bits to execute bits.
+ stat.mode = stat.mode | (stat.mode & 292) >> 2;
+ }
} catch (e) {
if (e && e.node && PATH.normalize(path) !== PATH.normalize(FS.getPath(e.node))) {
return -54;
@@ -67171,6 +67211,11 @@ function init9(RuntimeName, PHPLoader) {
doStat: function(func, path, buf) {
try {
var stat = func(path);
+ if (NODEFS.isWindows) {
+ // Node.js on Windows never represents permission bit 'x', so
+ // propagate read bits to execute bits.
+ stat.mode = stat.mode | (stat.mode & 292) >> 2;
+ }
} catch (e) {
if (e && e.node && PATH.normalize(path) !== PATH.normalize(FS.getPath(e.node))) {
return -54;