Fix gradient color on onboarding for Spanish - #720
Conversation
fredrikekelund
left a comment
There was a problem hiding this comment.
This change works, but it feels quite brittle to me. I played around with the text and found that setting line-height: normal on the L23 div moves the g descender inside the content box. It also increases the height of each row, so we need to compensate for that by setting a negative gap, margin or something.
I think it's worth the effort, though. This solution could easily break again down the line.
|
Thanks for the suggestion! I found that replacing
|
|
The diff looks cleaner now, but we are still using an arbitrary value for the padding to make the gradient cover the entire Still, I acknowledge that it's unlikely this will come back and bite us anytime soon, so perhaps it's best to just land this PR and leave it this way for now. The solution definitely works 🙂 |



Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist