Skip to content

Clean up error messages displayed in the error box #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcotrim merged 7 commits into from
Dec 20, 2024
Merged

Clean up error messages displayed in the error box #756

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cc8e7b0
clean up error messages displayed in the error box
bcotrim Dec 19, 2024
48be7f0
update logs button
bcotrim Dec 20, 2024
59be696
adjust show open logs logic and remove logging
bcotrim Dec 20, 2024
784b87d
Merge branch 'trunk' into add/clean_error_messages
wojtekn Dec 20, 2024
dbdcdab
Bring back logic that filters IPC handler wording
wojtekn Dec 20, 2024
f3f87c1
Show logs button when Studio fails to start site
wojtekn Dec 20, 2024
16d858f
fix unit test
bcotrim Dec 20, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bring back logic that filters IPC handler wording
  • Loading branch information
@wojtekn
wojtekn committed Dec 20, 2024
commit dbdcdab43b295724213ee28c8a7ff19868210f9b
7 changes: 6 additions & 1 deletion src/ipc-handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,10 +934,15 @@ export async function showErrorMessageBox(
showOpenLogs = false,
}: { title: string; message: string; error?: unknown; showOpenLogs?: boolean }
) {
// Remove prepended error message added by IPC handler
const filteredError = ( error as Error )?.message?.replace(
/Error invoking remote method '\w+': Error:/g,
''
);
const response = await showMessageBox( event, {
type: 'error',
message: title,
detail: error ? `${ message }\n\n${ error }` : message,
detail: error ? `${ message }\n\n${ filteredError }` : message,
buttons: [ ...( showOpenLogs ? [ __( 'Open Studio Logs' ) ] : [] ), __( 'OK' ) ],
} );

Expand Down