Skip to content

change placement of topbar elements tooltip to bottom-start #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katinthehatsite merged 1 commit into from
Dec 20, 2024
Merged

change placement of topbar elements tooltip to bottom-start #757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/top-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,16 @@ interface TopBarProps {
onToggleSidebar: () => void;
}

const DEFAULT_TOOLTIP_PLACEMENT = 'bottom-start';

function ToggleSidebar( { onToggleSidebar }: TopBarProps ) {
return (
<div className="app-no-drag-region">
<Tooltip text={ __( 'Toggle sidebar' ) } className="h-6">
<Tooltip
text={ __( 'Toggle sidebar' ) }
className="h-6"
placement={ DEFAULT_TOOLTIP_PLACEMENT }
>
<Button onClick={ onToggleSidebar } variant="icon" aria-label={ __( 'Toggle sidebar' ) }>
<Icon className="text-white" icon={ drawerLeft } size={ 24 } />
</Button>
Expand All @@ -44,6 +50,7 @@ function OfflineIndicator() {
</span>
}
className="h-6"
placement={ DEFAULT_TOOLTIP_PLACEMENT }
>
<Button
aria-label={ __( 'Offline indicator' ) }
Expand Down