Skip to content

Studio: Fix spacing between the offline and toggle sidebar icons for RTL languages - #759

Merged
katinthehatsite merged 1 commit into
trunkfrom
fix/spacing-icons-topbar-rtl
Dec 23, 2024
Merged

Studio: Fix spacing between the offline and toggle sidebar icons for RTL languages#759
katinthehatsite merged 1 commit into
trunkfrom
fix/spacing-icons-topbar-rtl

Conversation

@katinthehatsite

@katinthehatsite katinthehatsite commented Dec 20, 2024

Copy link
Copy Markdown
Contributor

Related issues

Closes https://github.com/Automattic/dotcom-forge/issues/10167

Proposed Changes

This PR adds spacing between the offline icon and toggle sidebar button in the topbar for rtl languages:

Before

Screenshot 2024-12-20 at 3 41 18 PM

After

Screenshot 2024-12-20 at 4 39 11 PM

Testing Instructions

  • Pull the changes from this branch
  • Start Studio with npm start
  • Switch the app to RTL language e.g. Hebrew
  • Turn off WiFi to display the offline icon
  • Observe the spacing between the icons
  • Switch back to LTR language
  • Confirm that the spacing looks correct and remains unaffected

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@katinthehatsite katinthehatsite self-assigned this Dec 20, 2024
@katinthehatsite
katinthehatsite requested a review from a team December 20, 2024 21:42
@katinthehatsite
katinthehatsite merged commit 3dc4114 into trunk Dec 23, 2024
@katinthehatsite
katinthehatsite deleted the fix/spacing-icons-topbar-rtl branch December 23, 2024 15:22
@ivan-ottinger

Copy link
Copy Markdown
Contributor

Great catch, Kat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants