Skip to content

Update default PHP version to 8.2 - #767

Merged
wojtekn merged 1 commit into
trunkfrom
update/default-php-version
Jan 3, 2025
Merged

Update default PHP version to 8.2#767
wojtekn merged 1 commit into
trunkfrom
update/default-php-version

Conversation

@wojtekn

@wojtekn wojtekn commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • I propose to update the default PHP version to 8.2. The 8.1 no longer gets security upgrades, so 8.2 should be considered as the minimum version that should be used for the WP site.

Testing Instructions

  1. Create a Studio site
  2. Confirm it uses PHP 8.2 by default
  3. Confirm site works e.g. WP Admin and frontend loads fine

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@wojtekn
wojtekn requested a review from a team January 3, 2025 08:59
@wojtekn wojtekn self-assigned this Jan 3, 2025

@sejas sejas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the new created sites use the PHP 8.2
Existing sites use the former PHP version, in my case 8.0.

Code changes look clean. We are still using 8.0 in some tests but that seems valid and tests pass correctly.

The new site with PHP 8.2 works as expected and feels faster.

Screenshot 2025-01-03 at 10 06 23
@ivan-ottinger
ivan-ottinger self-requested a review January 3, 2025 09:22

@ivan-ottinger ivan-ottinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes look good and a new site created is using PHP version 8.2 by default now.

I haven't observed any issues. The site and their WP Admin is loading correctly, similarly as Antonio observed.

@wojtekn
wojtekn merged commit 36f29d0 into trunk Jan 3, 2025
@wojtekn
wojtekn deleted the update/default-php-version branch January 3, 2025 09:31
@wojtekn

wojtekn commented Jan 3, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for review @sejas and @ivan-ottinger !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants