Studio: Include showDomainStep in the Create new site button URL - #774
Merged
ivan-ottinger merged 2 commits intoJan 7, 2025
Merged
Conversation
fredrikekelund
approved these changes
Jan 6, 2025
fredrikekelund
left a comment
fredrikekelund
left a comment
Contributor
There was a problem hiding this comment.
LGTM and tests well 👍
ivan-ottinger
deleted the
add/domain-step-to-sync-create-new-wpcom-business-site-flow
branch
January 7, 2025 08:51
Contributor
Author
→ Created a new task: https://github.com/Automattic/dotcom-forge/issues/10205 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
showDomainStepin theCreate new sitebutton URLTesting Instructions
npm start.Synctab and click on theCreate new sitebutton.Choose a domainstep and should let you follow through the WPCOM site creation flow without any issues.ℹ️ Please note there is a couple of existing styling issues on the
Choose a domainstep in Calypso which I am planning to look at next week.Pre-merge Checklist