Studio: Fix spacing in top bar - #776
Merged
Merged
Conversation
ivan-ottinger
approved these changes
Jan 8, 2025
ivan-ottinger
left a comment
ivan-ottinger
left a comment
Contributor
There was a problem hiding this comment.
Nice fix! The proposed changes look good in my tests. 👌🏼
What I think we could also consider is to adjust the left/right margins to make the RTL version look similar to the LTR. Here's what I mean:
Screen.Capture.on.2025-01-08.at.10-12-02.mp4
With the current styling, the space between the icons is slightly different when comparing LTR vs RTL versions.
Regardless, I am approving the PR as we may also consider the above change in a separate PR. 🙂
Contributor
Author
|
Good catch @ivan-ottinger. I’ve addressed this in d31e8db. Screen.Recording.2025-01-08.at.09.51.36.mov |
ivan-ottinger
self-requested a review
January 8, 2025 10:04
ivan-ottinger
approved these changes
Jan 8, 2025
ivan-ottinger
left a comment
ivan-ottinger
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @matt-west! Looks and works great on RTL now as well! 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes https://github.com/Automattic/dotcom-forge/issues/10177
Proposed Changes
Testing Instructions
Pre-merge Checklist