Skip to content

Keep custom path open if user selected one - #787

Merged
wojtekn merged 3 commits into
trunkfrom
fix/opening-path-dialog
Jan 9, 2025
Merged

Keep custom path open if user selected one#787
wojtekn merged 3 commits into
trunkfrom
fix/opening-path-dialog

Conversation

@wojtekn

@wojtekn wojtekn commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • I propose to change how a new site dialog form opens the directory dialog, to use the previously selected path if the user selected it already.

Testing Instructions

  1. Start Studio
  2. Click 'Add site'
  3. In the form, open 'Advanced settings'
  4. Select a directory different from the default path, existing or a new one
  5. Open the directory picker again
  6. Confirm that the opened directory is the local path you created/selected previously

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@wojtekn
wojtekn requested review from a team and bgrgicak January 8, 2025 11:57
@wojtekn wojtekn self-assigned this Jan 8, 2025

@bgrgicak bgrgicak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement 🚀

@bgrgicak

bgrgicak commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

@wojtekn I pushed a linter fix, hope that you don't mind it f7a1e81

@fredrikekelund fredrikekelund left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wojtekn

wojtekn commented Jan 9, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for pushing the lint fix @bgrgicak, and thank you and @fredrikekelund for the review. 🥳

@wojtekn
wojtekn merged commit a0aacb7 into trunk Jan 9, 2025
@wojtekn
wojtekn deleted the fix/opening-path-dialog branch January 9, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants