Skip to content

Update demo sites to open link in browser instead of copying the link #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sejas merged 2 commits into from
Jan 9, 2025
Merged

Update demo sites to open link in browser instead of copying the link #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
647fede
Replace copy dmeo link with open in browser
sejas Jan 8, 2025
8176093
add test
sejas Jan 8, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/components/content-tab-snapshots.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ import { useSnapshots } from '../hooks/use-snapshots';
import { useUpdateDemoSite } from '../hooks/use-update-demo-site';
import { cx } from '../lib/cx';
import { getIpcApi } from '../lib/get-ipc-api';
import { ArrowIcon } from './arrow-icon';
import { Badge } from './badge';
import Button from './button';
import { CopyTextButton } from './copy-text-button';
import offlineIcon from './offline-icon';
import ProgressBar from './progress-bar';
import { ScreenshotDemoSite } from './screenshot-demo-site';
Expand Down Expand Up @@ -189,13 +189,16 @@ function SnapshotRow( {
</div>
<Badge>{ __( 'Demo site' ) }</Badge>
</div>
<CopyTextButton
text={ urlWithHTTPS }
label={ `${ urlWithHTTPS }, ${ __( 'Copy site url to clipboard' ) }` }
copyConfirmation={ __( 'Copied!' ) }
<Button
variant="link"
className="!text-a8c-gray-70 hover:!text-a8c-blueberry max-w-[100%]"
onClick={ () => {
getIpcApi().openURL( urlWithHTTPS );
} }
>
{ urlWithHTTPS }
</CopyTextButton>
<span className="truncate">{ urlWithHTTPS }</span>
<ArrowIcon />
</Button>
<div className="mt-2 text-a8c-gray-70 whitespace-nowrap overflow-hidden truncate flex-1">
{ sprintf( __( 'Expires in %s' ), countDown ) }
</div>
Expand Down
27 changes: 26 additions & 1 deletion src/components/tests/content-tab-snapshots.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ const archiveSite = jest.fn();
jest.mock( '../../hooks/use-archive-site' );

const mockShowMessageBox = jest.fn();
const mockOpenURL = jest.fn();
jest.mock( '../../lib/get-ipc-api', () => ( {
getIpcApi: () => ( {
openURL: jest.fn(),
openURL: mockOpenURL,
generateProposedSitePath: jest.fn(),
showMessageBox: mockShowMessageBox,
} ),
Expand Down Expand Up @@ -432,6 +433,30 @@ describe( 'ContentTabSnapshots', () => {
expect( clearSnapshotsButton ).not.toBeInTheDocument();
} );
} );

test( 'clicking the demo site URL opens the browser', async () => {
const user = userEvent.setup();
( useSnapshots as jest.Mock ).mockReturnValue( {
snapshots: [
{
url: 'fake-site.fake',
atomicSiteId: 150,
localSiteId: 'site-id-1',
date: new Date().getTime(),
deleted: false,
},
],
fetchSnapshotUsage: jest.fn(),
} );

render( <ContentTabSnapshots selectedSite={ selectedSite } /> );

const urlButton = screen.getByRole( 'button', { name: 'https://fake-site.fake ↗' } );
expect( urlButton ).toBeVisible();
await user.click( urlButton );

expect( mockOpenURL ).toHaveBeenCalledWith( 'https://fake-site.fake' );
} );
} );

describe( 'AddDemoSiteWithProgress', () => {
Expand Down