Studio: Open the site's URL from the Sync connect popup - #799
Merged
Conversation
katinthehatsite
commented
Jan 10, 2025
| ? '!text-inherit hover:!text-inherit' | ||
| : '!text-a8c-gray-30 hover:!text-a8c-gray-30' | ||
| ) } | ||
| onClick={ () => getIpcApi().openURL( site.url ) } |
Contributor
Author
There was a problem hiding this comment.
I did not add this arrow but perhaps we can consider adding it to indicate to the user that it is a link:
What do you think?
Contributor
There was a problem hiding this comment.
Yes, we should stick to this convention to provide consistent UX.
Contributor
Author
There was a problem hiding this comment.
Sounds good, I made updates in 4ab21ae
Let me know what you think!
wojtekn
approved these changes
Jan 15, 2025
wojtekn
left a comment
wojtekn
left a comment
Contributor
There was a problem hiding this comment.
The code change looks clear. It works as expected.
| ? '!text-inherit hover:!text-inherit' | ||
| : '!text-a8c-gray-30 hover:!text-a8c-gray-30' | ||
| ) } | ||
| onClick={ () => getIpcApi().openURL( site.url ) } |
…te-url-from-sync-popup
Contributor
|
I've just restarted remaining build. |
Contributor
Author
|
Thanks @wojtekn - I restarted twice yesterday but it was taking forever. It seems like a glitch, everything is passing now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Closes https://github.com/Automattic/dotcom-forge/issues/10080
Proposed Changes
This PR makes the URLs in the sync modal open the site when you click on a specific site URL:
Testing Instructions
npm startSynctabConnect sitePre-merge Checklist