Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
3031fcf
Skip Sentry initialization in E2E tests
bcotrim Jan 16, 2025
12b9b51
also remove sentry init from unit tests
bcotrim Jan 16, 2025
1706287
disable steps for debugging
bcotrim Jan 16, 2025
0b22817
enable some steps for debugging
bcotrim Jan 16, 2025
916bfca
add building variable
bcotrim Jan 16, 2025
65bbe35
disable steps for debugging
bcotrim Jan 16, 2025
7173291
enable mac build
bcotrim Jan 16, 2025
6d9f7d5
remove dev version changes
bcotrim Jan 16, 2025
925c585
remove sentry init
bcotrim Jan 16, 2025
d43e1dd
remove sentry init
bcotrim Jan 16, 2025
05108dc
adjust webpack sentry plugin
bcotrim Jan 16, 2025
7de7e7b
adjust webpack sentry plugin
bcotrim Jan 16, 2025
bee1b83
revert unnecessary changes
bcotrim Jan 16, 2025
bfa5f32
revert unnecessary changes
bcotrim Jan 16, 2025
94b73d2
check if windows is failing
bcotrim Jan 16, 2025
9736e3e
check if e2e is causing issues
bcotrim Jan 16, 2025
a39fe9a
attempt to fix e2e issue
bcotrim Jan 16, 2025
3f8b3bd
attempt to fix windows build
bcotrim Jan 16, 2025
f5ac5cc
rename DEV_BUILD to IS_DEV_BUILD for consistency
bcotrim Jan 17, 2025
79eeaba
add variable to root
bcotrim Jan 20, 2025
9e33c33
add more details to debug issue source
bcotrim Jan 20, 2025
3821092
add more details to debug issue source
bcotrim Jan 20, 2025
148fc53
add more details to debug issue source
bcotrim Jan 20, 2025
85d34f6
add more details to debug issue source
bcotrim Jan 20, 2025
383b915
add more details to debug issue source
bcotrim Jan 20, 2025
83b9b64
add more details to debug issue source
bcotrim Jan 20, 2025
b29a0b5
add more details to debug issue source
bcotrim Jan 20, 2025
d6de390
add more details to debug issue source
bcotrim Jan 20, 2025
2c69da5
add more details to debug issue source
bcotrim Jan 20, 2025
1af221c
cleanup
bcotrim Jan 20, 2025
a331eb2
cleanup
bcotrim Jan 20, 2025
663601b
fix windows build
bcotrim Jan 20, 2025
ed9143a
cleanup
bcotrim Jan 20, 2025
9138adf
add IS_DEV_BUILD to env param
bcotrim Jan 21, 2025
511b1b2
update IS_DEV_BUILD for e2e step
bcotrim Jan 21, 2025
c8ce53a
update IS_DEV_BUILD for remaining steps
bcotrim Jan 21, 2025
0462f1c
remove unnecessary E2E check from Sentry init
bcotrim Jan 22, 2025
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update IS_DEV_BUILD for remaining steps
  • Loading branch information
bcotrim committed Jan 21, 2025
commit c8ce53aedfb9593bf1620dff084ec1538c777e60
10 changes: 7 additions & 3 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,10 @@ steps:

node ./scripts/prepare-dev-build-version.mjs

export IS_DEV_BUILD=true

echo "--- :node: Building Binary"
IS_DEV_BUILD=true npm run make:macos-{{matrix}}
npm run make:macos-{{matrix}}

# Local trial and error show this needs to run before the DMG generation (obviously) but after the binary has been built
echo "--- :hammer: Rebuild fs-attr if necessary before generating DMG"
Expand All @@ -108,7 +110,7 @@ steps:
esac

echo "--- :node: Packaging in DMG"
IS_DEV_BUILD=true npm run make:dmg-{{matrix}}
npm run make:dmg-{{matrix}}

echo "--- 📃 Notarizing Binary"
bundle exec fastlane notarize_binary
Expand Down Expand Up @@ -154,8 +156,10 @@ steps:

.buildkite/commands/install-node-dependencies.sh

export IS_DEV_BUILD=true

echo "--- :node: Generating Release Manifest"
IS_DEV_BUILD=true node ./scripts/generate-releases-manifest.mjs
node ./scripts/generate-releases-manifest.mjs

echo "--- :fastlane: Distributing Dev Builds"
install_gems
Expand Down