Skip to content

Add a 'Local path' field label and a doc link - #828

Merged
wojtekn merged 2 commits into
trunkfrom
add/local-path-field-label
Jan 23, 2025
Merged

Add a 'Local path' field label and a doc link#828
wojtekn merged 2 commits into
trunkfrom
add/local-path-field-label

Conversation

@wojtekn

@wojtekn wojtekn commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

I propose to add a 'Local path' field label to explain accepted directory formats. I also propose adding a 'Learn more' link pointing to the documentation page, which explains this better.

Screenshot 2025-01-22 at 11 26 27 Screenshot 2025-01-22 at 11 17 10

Testing Instructions

  1. Check if the 'Add site' form still works fine and allows selecting a local path
  2. Validate the same in the Onboarding form
  3. Validate if message is clear enough

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@wojtekn
wojtekn requested a review from a team January 22, 2025 10:25
@wojtekn wojtekn self-assigned this Jan 22, 2025

@ivan-ottinger ivan-ottinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes look good and the new copy is clear to me. 👌🏼

The Add site and Onboarding forms are working correctly and I did not observe any regression.

There's just one styling issue I noticed: The vertical spacing is different when we compare the Import a backup vs Local path sections:

Markup on 2025-01-22 at 11:39:37

@wojtekn

wojtekn commented Jan 22, 2025

Copy link
Copy Markdown
Contributor Author

@ivan-ottinger good catch. I unified both fields' markups, and now, the spacing between the field name, label, and field itself should be consistent.

@ivan-ottinger ivan-ottinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivan-ottinger good catch. I unified both fields' markups, and now, the spacing between the field name, label, and field itself should be consistent.

Nice! The proposed changes look good. 👌🏼 The vertical spacing is consistent now:

Markup on 2025-01-23 at 10:09:18

@wojtekn
wojtekn merged commit e6225ed into trunk Jan 23, 2025
@wojtekn
wojtekn deleted the add/local-path-field-label branch January 23, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants