Switch to yauzl for unzipping files without loading everything into memory - #835
Merged
Conversation
fredrikekelund
approved these changes
Jan 24, 2025
fredrikekelund
left a comment
fredrikekelund
left a comment
Contributor
There was a problem hiding this comment.
Looks great and works as expected 👍
For completeness sake (I'm currently working on https://github.com/Automattic/dotcom-forge/issues/7611), I can also confirm that the new tests also pass on Windows.
wojtekn
approved these changes
Jan 27, 2025
wojtekn
left a comment
wojtekn
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Make sense to implement improvements proposed by @fredrikekelund , though.
Co-authored-by: Fredrik Rombach Ekelund <fredrik@f26d.dev>
Co-authored-by: Fredrik Rombach Ekelund <fredrik@f26d.dev>
Co-authored-by: Fredrik Rombach Ekelund <fredrik@f26d.dev>
Member
Author
|
@fredrikekelund Thanks for the detailed code review! ❤️ |
1 task
bgrgicak
pushed a commit
that referenced
this pull request
Jan 29, 2025
…emory (#835) * switch to yauzl for unzipping files without loading everything into memory * change import syntax that's used Co-authored-by: Fredrik Rombach Ekelund <fredrik@f26d.dev> * promisifying openReadStream Co-authored-by: Fredrik Rombach Ekelund <fredrik@f26d.dev> * using await with openReadStream Co-authored-by: Fredrik Rombach Ekelund <fredrik@f26d.dev> --------- Co-authored-by: Fredrik Rombach Ekelund <fredrik@f26d.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
adm-ziplib in favor ofyauzlwhich is more mature & adheres to spec tightlyTesting Instructions
Pre-merge Checklist