Use path.posix.join for relevant paths - #878
Merged
fredrikekelund merged 1 commit intoFeb 3, 2025
Merged
Conversation
nightnei
approved these changes
Feb 3, 2025
nightnei
left a comment
nightnei
left a comment
Contributor
There was a problem hiding this comment.
Works well with MacOS and Windows 👍 Thanks
fredrikekelund
deleted the
f26d/fix-playground-internal-paths-on-windows
branch
February 3, 2025 14:43
sejas
reviewed
Feb 3, 2025
sejas
left a comment
sejas
left a comment
Member
There was a problem hiding this comment.
Thank you for the quick fix! ❤️
Contributor
|
Thanks for fixing this @fredrikekelund TIL! Should we add a linter rule to discourage the use of |
Contributor
Author
In other places (anything related to the computer's regular file system), the platform-awareness of It's worth noting that since #839, we're running a CI job with unit tests on Windows again. Hopefully, that should help catch similar issues in the future 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
This PR fixes a regression from #845. In that PR, we moved all mu-plugins but the SQLite one to be mounted in Playground's internal mu-plugins directory to give back more control to users over the regular mu-plugins directory.
The problem is that we use
path.joinfor the paths passed tophp.writeFile. Thephp.writeFileseems to expect Unix-style paths, butpath.joinis platform-aware, meaning we get Windows-style paths on Windows.This PR fixes that problem by using
path.posix.joininstead.Testing Instructions
Ensure that starting a server works as expected on Windows
Pre-merge Checklist