Generate always available name for a new website by nightnei · Pull Request #900 · Automattic/studio

nightnei · 2025-02-06T12:11:56Z

Proposed Changes

When you run out of available names, there is very weird result: after clicking "Add site" button we immediately see the next:

With this PR, the generation of names is always successful (we add numeric postfix), so users don't need to do extra actions and spend time to figure out "what is going on" .

Testing Instructions

Apply the next diff:

diff --git a/src/lib/generate-site-name.ts b/src/lib/generate-site-name.ts
index 3052a2f..ae3e6ad 100644
--- a/src/lib/generate-site-name.ts
+++ b/src/lib/generate-site-name.ts
@@ -4,24 +4,6 @@ export function generateSiteName( usedSiteNames: string[] ): string {
        const siteNames = [
                __( 'My Bold Website' ),
                __( 'My Bright Website' ),
-               __( 'My Blissful Website' ),
-               __( 'My Calm Website' ),
-               __( 'My Cool Website' ),
-               __( 'My Dreamy Website' ),
-               __( 'My Elite Website' ),
-               __( 'My Fresh Website' ),
-               __( 'My Glowing Website' ),
-               __( 'My Happy Website' ),
-               __( 'My Joyful Website' ),
-               __( 'My Noble Website' ),
-               __( 'My Pure Website' ),
-               __( 'My Peak Website' ),
-               __( 'My Prime Website' ),
-               __( 'My Serene Website' ),
-               __( 'My Shiny Website' ),
-               __( 'My Sparkly Website' ),
-               __( 'My Swift Website' ),
-               __( 'My True Website' ),
        ];
 
        const defaultName = __( 'My WordPress Website' );

Remove all websites
Assert that default website has name My WordPress Website and create it
"Add new" website and assert that it has random name between My Bold Website and My Bright Website
Add one more website and assert that it has the second name which left from previous step
Add new website and assert that we have numeric postfix and further generations increase postfix correctly for random name

sejas

Left a couple of suggestions.
I think adding a postfix is an improvement 💪

In addition to this, we could increase our list of default sitenames by having a really long list of adjetives produced by an LLM and then use something like sprintf( __( 'My %s Website' ), adjetive ),

sejas · 2025-02-07T15:32:53Z

 	const CYRILLIC = 'а-яё';
 	const ARABIC = '\\u0600-\\u06FF';
-	const HEBREW = '\\u0590-\\u05FF';
+	const HEREW = '\\u0590-\\u05FF';


I think this change is not intentional.

sejas · 2025-02-07T15:34:38Z

+	while ( usedSiteNames.includes( `${ randomName } ${ postfix }` ) ) {
+		postfix++;
+	}
+	return `${ randomName } ${ postfix }`;


Should we take into account RTL languages ? For those languages the postfix should be on the left.

Would it make sense to always use My WordPress Website for subsequent names with the number, so user who uses all random names will keep getting My WordPress Website 1, My WordPress Website 2 and so on?

Personally for me, it's one more good option. And I don't see any pros/cons, anyway it's more kinda "Temporary name", 99% that the user will change it to something connected with their website, unless it's testing site.
Only one good thing what I see with the current approach is that we have diversity of names 😅
So I would go with either proposed approach by me or remove all adjectives and keep only My WordPress Website ${number}. But I am ok with any approach, as long as we provide unique names.

UPDATE, Oh, I guess you meant exactly to use only subsequent names of My WordPress Website and remove adjective options, right? If so, ignore my previous message and I think that it's good simple approach too, I don't have strong preference either to use it or keep proposed by me.

Yes, this is what I meant. So the order would look as follows:

My WordPress Website

One of My RANDOM Website names

My WordPress Website 1

My WordPress Website 2
This seems to be the least confusing to me.

wojtekn · 2025-02-10T10:44:56Z

+	while ( usedSiteNames.includes( `${ randomName } ${ postfix }` ) ) {
+		postfix++;
+	}
+	return `${ randomName } ${ postfix }`;


Would it make sense to always use My WordPress Website for subsequent names with the number, so user who uses all random names will keep getting My WordPress Website 1, My WordPress Website 2 and so on?

wojtekn · 2025-02-10T10:46:03Z

+	}
+
+	const randomName = siteNames[ Math.floor( Math.random() * siteNames.length ) ];
+	let postfix = 1;


Should it be suffix instead of postfix? Or just a siteNumber to ensure it makes sense for LTR and RTL?

Should it be suffix instead of postfix? Or just a siteNumber to ensure it makes sense for LTR and RTL?

If we make it as suffix, then it will be confusing for LTR environments, since we used to see number at the end (e.g. in MacOS, Windows).
So my opinion, we should change postfix with suffix only for RTL.
WDYT?

My comment referred only to the variable name. postfix is the name of the mail-sending agent. I think it should be affix, instead, or even better, just siteNumber.

wojtekn

Works as expected. I'm just unsure if the first number should be 1 or 2, because in the end, "My WordPress Website 1" will be second site of that name. Not a big deal, though, as it's edge case.

fredrikekelund · 2025-02-13T10:05:57Z

I'm just unsure if the first number should be 1 or 2, because in the end, "My WordPress Website 1" will be second site of that name

I haven't reviewed the code here, but the commonsensical approach would be to start the counter from 2, IMO.

fix: generate always available name for a new website

59231be

nightnei requested a review from a team February 6, 2025 12:11

nightnei changed the title ~~fix: generate always available name for a new website~~ Feb 6, 2025

sejas reviewed Feb 7, 2025

View reviewed changes

wojtekn reviewed Feb 10, 2025

View reviewed changes

nightnei added 2 commits February 10, 2025 11:52

revert

c5abca9

chore: simplify increment

61ce201

wojtekn approved these changes Feb 13, 2025

View reviewed changes

chore: increment

a197f58

nightnei merged commit 9806694 into trunk Feb 13, 2025

nightnei deleted the fix/generateAlwaysAvailableNameForNewWebsite branch February 13, 2025 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Generate always available name for a new website - #900

Generate always available name for a new website#900
nightnei merged 4 commits into
trunkfrom
fix/generateAlwaysAvailableNameForNewWebsite

nightnei commented Feb 6, 2025 •

edited

Loading

sejas left a comment

sejas Feb 7, 2025

sejas Feb 7, 2025

wojtekn Feb 10, 2025

nightnei Feb 10, 2025

nightnei Feb 10, 2025 •

edited

Loading

wojtekn Feb 11, 2025

nightnei Feb 12, 2025

wojtekn Feb 10, 2025

wojtekn Feb 10, 2025

nightnei Feb 10, 2025

wojtekn Feb 11, 2025

wojtekn left a comment

fredrikekelund commented Feb 13, 2025

Labels

4 participants

Uh oh!

Conversation

nightnei commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Testing Instructions

sejas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nightnei Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wojtekn left a comment

Choose a reason for hiding this comment

fredrikekelund commented Feb 13, 2025

Labels

4 participants

nightnei commented Feb 6, 2025 •

edited

Loading

nightnei Feb 10, 2025 •

edited

Loading