Set higher timeouts for import/export wp-cli commands - #904
Conversation
sejas
left a comment
There was a problem hiding this comment.
The changes look good. Increasing the import process will allow users to import websites with more content.
To establish reasonable limits, we might need to benchmark the amount of content imported on a typical computer and set a limit based on those metrics.
I’ve added a couple of suggestions, please let me know what you think.
b82e923 to
b427255
Compare
sejas
left a comment
There was a problem hiding this comment.
@ashfame, Thanks for considering my suggestions. I like the new approach where wp-cli-process handles selecting the timeout based on the command.
I've tested it and confirmed that the timeout for SQLite export and import processes is 6 hours, while the rest of wp-cli commands still 5 minutes.
I've left a couple of non-blocking comments.
Co-authored-by: Antonio Sejas <antonio.sejas@automattic.com>
|
@sejas Thanks for the review! I made both the changes. Will merge shortly 👍 |
Related issues
Proposed Changes
longRunning: truetoexecuteWpCliCommand()Testing Instructions
Pre-merge Checklist