build: Suppress sentry-webpack-plugin logs - #91
Merged
Conversation
dcalhoun
force-pushed
the
build/supress-sentry-webpack-plugin-logs
branch
from
May 6, 2024 14:30
a70b8c7 to
cade8c0
Compare
Avoid unnecessary development environment noise from a production-only plugin.
dcalhoun
force-pushed
the
build/supress-sentry-webpack-plugin-logs
branch
from
May 6, 2024 14:30
cade8c0 to
d350f51
Compare
dcalhoun
marked this pull request as ready for review
May 6, 2024 14:38
sejas
approved these changes
May 6, 2024
sejas
left a comment
Member
There was a problem hiding this comment.
Nice It works as described and now the dev log is cleaner. Thanks!
npm start 14s Node 20.9.0 21:41:36
> studio@1.0.1 start
> electron-forge start
✔ Checking your system
✔ Locating application
✔ Locating application
✔ Loading configuration
✔ Preparing native dependencies: 1 / 1 [0.2s]
✔ Running generateAssets hook
✔ [plugin-webpack] Compiling main process code [3s]
✔ [plugin-webpack] Compiling main process code [3s]
✔ [plugin-webpack] Compiling main process code [3s]
✔ [plugin-webpack] Launching dev servers for renderer process code [7s]
› Output Available: http://localhost:9000
vs
SENTRY_AUTH_TOKEN='mock-value' npm start х INT Node 20.9.0 21:42:18
> studio@1.0.1 start
> electron-forge start
✔ Checking your system
✔ Locating application
✔ Locating application
✔ Loading configuration
✔ Preparing native dependencies: 1 / 1 [0.3s]
✔ Running generateAssets hook
⠋ [plugin-webpack] Compiling main process code
◼ [plugin-webpack] Launching dev servers for renderer process code
⠧ [plugin-webpack] Compiling main process code
◼ [plugin-webpack] Launching dev servers for renderer process code
⠋ [plugin-webpack] Compiling main process code
◼ [plugin-webpack] Launching dev servers for renderer process code
error: API request failed
caused by: sentry reported an error: Invalid token (http status: 401)
⠙ [plugin-webpack] Compiling main process code
◼ [plugin-webpack] Launching dev servers for renderer process code
An unhandled rejection has occurred inside Forge:
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Avoid unnecessary development environment noise from a production-only
plugin.
Testing Instructions
Verify no logs display when environment variable is undefined
npm startsentry-webpack-pluginvalues display in the server log.Verify logs display when environment variable is defined
SENTRY_AUTH_TOKEN='mock-value' npm startsentry-webpack-pluginvalues display in the server log (a Sentry permission error will display due to an invalid token value).Pre-merge Checklist