Skip to content

fix: Improve focus style consistency #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcalhoun merged 2 commits into from
May 7, 2024
Merged

fix: Improve focus style consistency #92

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08552a5
fix: Prefer `focus-visible` styles over `focusable`
dcalhoun May 6, 2024
fa87916
refactor: Remove unnecessary styles
dcalhoun May 6, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: Remove unnecessary styles 
These do not appear to have an impact as the `li` element is not
focusable. The button child receives focus and has its own focus styles.
  • Loading branch information
@dcalhoun
dcalhoun committed May 6, 2024
commit fa879167983b86bdff798bc63849f1691abb1b4e
4 changes: 2 additions & 2 deletions src/components/site-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@ function SiteItem( { site }: { site: SiteDetails } ) {
return (
<li
className={ cx(
'flex flex-row min-w-[168px] h-8 hover:bg-[#ffffff0C] focus:bg-[#ffffff0C] rounded transition-all',

@dcalhoun dcalhoun May 6, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The focus styles applied to the li element did not appear to have an impact, as the element is not focusable. The child button is the element focused when moving focus with the keyboard, which has its own focus styles with an outline.
'flex flex-row min-w-[168px] h-8 hover:bg-[#ffffff0C] rounded transition-all',
isMac() ? 'mx-5' : 'mx-4',
isSelected && 'bg-[#ffffff19] hover:bg-[#ffffff19] focus:bg-[#ffffff19]'
isSelected && 'bg-[#ffffff19] hover:bg-[#ffffff19]'
) }
>
<button
Expand Down