Skip to content

Fix: Sidebar layout breaks on specific languages - #93

Merged
katinthehatsite merged 1 commit into
trunkfrom
fix/sidebar-layout-different-languages
May 8, 2024
Merged

Fix: Sidebar layout breaks on specific languages#93
katinthehatsite merged 1 commit into
trunkfrom
fix/sidebar-layout-different-languages

Conversation

@katinthehatsite

Copy link
Copy Markdown
Contributor

Closes ##40

Proposed Changes

This PR aligns the WordPress logo and Log in so that the layout is more consistent in multiple languages.

Before After

Testing Instructions

  • Pull the changes from this branch locally
  • Select the language in your system to be French
  • Start the app with nvm use && npm install && npm start
  • Observe that the words Se connecter are aligned in the sidebar are aligned to the right and towards the bottom
  • Quit the app
  • Try switching the languages to other such as Spanish, Polish, English and confirm that the Log in either remains on one line (when the word is short, or is aligned to the right when there are two lines)

Notes

  • You can find a bit more discussions regarding this issue here. I initially considered making the sidebar more dynamic and size it based on what is inside it to keep everything on the same line but decided against it because:
  • it might look too overpowering if the words are too long for the Log in in some languages;
  • it might affect how it looks like on other operating systems.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better now, thanks for the fix.

@katinthehatsite
katinthehatsite merged commit e6a7385 into trunk May 8, 2024
@katinthehatsite
katinthehatsite deleted the fix/sidebar-layout-different-languages branch May 8, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants