Skip to content

Install the SQLite database integration plugin from the A8C repository - #950

Merged
wojtekn merged 14 commits into
trunkfrom
update/pull-sqlite-plugin-from-a8c-fork
Mar 25, 2025
Merged

Install the SQLite database integration plugin from the A8C repository#950
wojtekn merged 14 commits into
trunkfrom
update/pull-sqlite-plugin-from-a8c-fork

Conversation

@bgrgicak

@bgrgicak bgrgicak commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

Testing Instructions

  • Run npm run postinstall
  • Confirm it doesn't fail
  • Open the wp-files/sqlite-database-integration folder inside your Studio project folder
  • Find the readme.md and confirm the plugin version is 2.1.17-alpha
  • Start a site and confirm wp-admin loads

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@bgrgicak

bgrgicak commented Feb 18, 2025

Copy link
Copy Markdown
Contributor Author
@bgrgicak

Copy link
Copy Markdown
Contributor Author

Resolve SQLite issue that prevents Studio from booting with the latest plugin version

I'm worried that even if we fix this issue, there might be more, so I'm thinking of creating a release based on the last commit before the SQLite driver was merged.

This would ensure Studio gets a stable update.

@bgrgicak

Copy link
Copy Markdown
Contributor Author

I'm worried that even if we fix this issue, there might be more, so I'm thinking of creating a release based on the last commit before the SQLite driver was merged.

I released a new SQLite database integration version without AST features.

@bgrgicak bgrgicak assigned bgrgicak and unassigned bgrgicak Feb 20, 2025
@bgrgicak
bgrgicak requested a review from a team February 20, 2025 07:51
@bgrgicak
bgrgicak marked this pull request as ready for review February 20, 2025 07:51
Comment thread src/lib/sqlite-database-integration-release.ts Outdated
@bgrgicak
bgrgicak requested a review from wojtekn March 3, 2025 07:38
@bgrgicak
bgrgicak force-pushed the update/pull-sqlite-plugin-from-a8c-fork branch from 6de72de to 5428859 Compare March 3, 2025 08:29
@bgrgicak

bgrgicak commented Mar 3, 2025

Copy link
Copy Markdown
Contributor Author

@wojtekn what would be a good place to document how SQLite plugin updates are handled?

@wojtekn

wojtekn commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

I've merged the trunk to this feature branch and solved conflicts. The PR works well - my new site uses 2.1.17-alpha and the old sites get the plugin upgraded when started.

As the SQLite plugin is downloaded when Studio is being built and bundled inside wp-file (in download-wp-server-files.ts), we could remove the whole code that downloads the plugin on run-time and always copy the bundled plugin.

@Automattic/yolo any thoughts?

@bgrgicak
bgrgicak force-pushed the update/pull-sqlite-plugin-from-a8c-fork branch from 48aeb7f to 2b1afd5 Compare March 20, 2025 07:05
@bgrgicak

Copy link
Copy Markdown
Contributor Author
@wojtekn

wojtekn commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

@wojtekn do you mean removing this code for downloading the SQLite plugin?

Correct, as far as I understand, the download should now happen only in download-wp-server-files.ts.

@bgrgicak

Copy link
Copy Markdown
Contributor Author

@wojtekn I removed the download code, could you please take another look?

@wojtekn

wojtekn commented Mar 24, 2025

Copy link
Copy Markdown
Contributor

Works as expected, thanks for cleaning up the code.

@sejas sejas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.
It installs the SQLite plugin from GitHub with version SQLITE_DATABASE_INTEGRATION_VERSION.
Sites start and stop correctly, I confirm I was able to save a page, and create a new site.
SQLite plugin won't be updated automatically from .org plugins repository anymore.
We'll need to create a new GitHub release of the plugin, and release a new Studio version updating the version constant.

Screenshot 2025-03-24 at 09 40 27

Comment thread src/lib/sqlite-database-integration-release.ts Outdated
@bgrgicak
bgrgicak requested a review from sejas March 24, 2025 10:41
@wojtekn
wojtekn merged commit 5747127 into trunk Mar 25, 2025
@wojtekn
wojtekn deleted the update/pull-sqlite-plugin-from-a8c-fork branch March 25, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants