Use CI toolkit plugin v5 and nvm plugin v0.4.0

[mokagio]

Related issues

• Internal ref pdnsEh-24x-p2

Proposed Changes

• Use nvm CI plugin v0.4.0 which has clearer logs
• Use CI toolkit plugin v5.0.0 which comes with more automation for Windows and allows us to remove custom scripts

Testing Instructions

Refer to green Windows CI builds

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors? – N.A.

[mokagio]

Not sure why IS_DEV_BUILD was set via $env: before and why it worked when the pipeline should have ignored the $ (see the docs).

Anyway, once I added the bash call, the resolution for the env assignment no longer worked.

Moving the env var definition in the env node seems to have done the trick. I can see in the CI logs that we have "Sentry environment: development" as per:

studio/webpack.plugins.ts

Line 10 in 98f29e1

console.log( 'Sentry environment:', isDevEnvironment ? 'development' : 'production' );

[wojtekn]

Thanks for adjusting that, it seems now it's done in more practical way.

We've added that under #813 to avoid initializing Sentry during CI runs.

[wojtekn]

Thanks for the cleanup.

[wojtekn]

Thanks for adjusting that, it seems now it's done in more practical way.

We've added that under #813 to avoid initializing Sentry during CI runs.

[AliSoftware]

🧹 🧹 🧹 👌