Support resized image dimensions - #107
Merged
Merged
Conversation
smithjw1
previously approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #106.
Previously, resized dimensions were overwritten by
src/parser/block-additions/core-image.php's addedwidthandheightdimensions. For example:This post contains two images, one original and one resized. The HTML reflects this:
The first image has no manual
widthorheightset, but the second image haswidth":"212px", "height":"auto"set in the block delimiter. Although these are different, when rendered through the block data API, the results are largely the same:That's because the delimiter-defined
widthandheightare overwritten by the image block addition. Following @codedbyglenden's idea, the fix in this PR preserves the attribute-set width and height inresize-widthandresize-heightattributes:widthandheightstill show the native image attachment version for backwards compatibility. Also, the delimiter-sourced attributes are strings ("212px","auto") instead of numbers, so a separate attribute feels like the safer path.