Skip to content

[WIP] Schnorr/Taproot/Tapscript#758

Open
afk11 wants to merge 29 commits into
Bit-Wasp:1.0from
afk11:schnorr
Open

[WIP] Schnorr/Taproot/Tapscript#758
afk11 wants to merge 29 commits into
Bit-Wasp:1.0from
afk11:schnorr

Conversation

@afk11

@afk11 afk11 commented Dec 16, 2018

Copy link
Copy Markdown
Member

Not for merge yet, but started working on a phpecc-backed implementation of the schnorr signature implementation a while back. Opening the PR so I don't forget about it
@faustbrian

faustbrian commented Jun 21, 2019

Copy link
Copy Markdown

What's the status on this?
@afk11

afk11 commented Jun 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Hey. The PR includes an implementation of bip-schnorr https://github.com/sipa/bips/blob/bip-schnorr/bip-schnorr.mediawiki using PHPECC. The implementation is working, but it could do with review by others, especially a cryptographer.

ext-secp256k1 also needs bindings written for schnorr, so we can utilize it here for the second EcAdapter implementation we provide. this stuff can probably come as a separate PR.

The taproot stuff is up for grabs, or I might get it over the next week or two.
@afk11 afk11 force-pushed the schnorr branch 3 times, most recently from 37dd375 to 7704249 Compare October 29, 2019 18:03
@afk11 afk11 changed the title [WIP] Add phpecc backed Schnorr implementation Nov 10, 2019
@afk11 afk11 changed the base branch from master to 1.0 November 11, 2019 12:44
@faustbrian faustbrian mentioned this pull request Nov 13, 2019
Closed
@afk11 afk11 force-pushed the schnorr branch 5 times, most recently from 48a9a76 to c9505db Compare December 10, 2019 23:53
Thomas Kerin and others added 14 commits December 11, 2019 00:04
@afk11
Add phpecc backed Schnorr implementation
b100ace
@afk11
add ext-gmp as requirement to composer.json
8b1ccdc
@afk11
EcAdapter: Add interfaces for Schnorr, and a secp256k1 backed impleme…
fce79fe 
…ntation for our EcAdapter
@afk11
TaprootHasher: Implement taproot transaction digest
32e510e
@afk11
Add schnorr signature verification methods to Checker
746b2d3
@afk11
OutputScriptFactory: add method for taproot output scripts
1808b4d
@afk11
XOnlyPublicKey: add constructor arg hasSquareY, returned during xonly…
09a78ed 
…_pubkey_from_pubkey
@afk11
Implement PublicKey::asXOnlyPublicKey
4be09f3
@afk11
Rewrite SchnorrSigner and implement missing Serializers
5828e8a
@afk11
Add PrecomputedData for signatures, and refactor TaprootHasher in ter…
bd591c8 
…ms thereof
@afk11
Taproot program validation. Excludes tapscript.
f5355bb
@afk11
Extract executeWitnessProgram as fallthrough is overwhelming, and now…
9514417 
… conditional (taproot-keypath-spend)
@afk11
TaprootHasher: tapscript modifications
6a2262b
@afk11
Taproot script validation step 2: tapscript validation succeeds if OP…
48f9e97 
…_SUCCESSx present
afk11 added 15 commits December 11, 2019 00:04
@afk11
Taproot script validation step 3: no max script length for tapscript
d0387fe
@afk11
Taproot script validation step 3: initial stack is restricted to MAX_…
ee12c06 
…STACK_SIZE
@afk11
Taproot script validation step 3: non-push opcode limit removed for t…
74c57ab 
…apscript
@afk11
witness limit initial stack size
be1a924
@afk11
extract evalChecksig method and fix checkPayToContract in both EcAdap…
2cd87bd 
…ter implementations
@afk11
validation weigh left: should include offset when initialized
2e00c8f
@afk11
tapscript execution: multisig opcodes disabled
1ae74ca
@afk11
tapscript execution: require MINIMALIF in tapscript
9eeaf79
@afk11
tapscript: implement OP_CHECKSIGADD
cec8ad8
@afk11
tapscript: update execContext with code sep opcode position
11a227d
@afk11
Move taproot constants to Interpreter namespace, not on Interpreter c…
521a579 
…lass
@afk11
TaprootConstructTest: test taprootConstruct with various tree structures
f0e54bd
@afk11
wip & bug: ExecutionContext had a logic error
68f354c
@afk11
add TaprootTest file that was forgotten
6f96f21
@afk11
travis: use schnorr version of secp256k1 / schnorrsig
5c0a5e7
@doxadoxa

doxadoxa commented Oct 11, 2020

Copy link
Copy Markdown
Contributor

Do you have any updates on this WIP?
@afk11

afk11 commented Oct 11, 2020

Copy link
Copy Markdown
Member Author

Hi, I left this on standby while libsecp worked things out, as there was quite a bit of code churn on their end. I noticed that PR was merged not too long ago, so might be worth look into this again soon.
@afk11 afk11 mentioned this pull request Jun 16, 2021
Open
7 tasks
@Chemaclass

Chemaclass commented Jan 27, 2025

Copy link
Copy Markdown

Any updates on this one? :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@afk11 @faustbrian @doxadoxa @Chemaclass