fix undefined warning on non getpgid systems - #615
Merged
Conversation
jamesros161
marked this pull request as ready for review
February 17, 2025 17:24
bwmarkle
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #614
The warning received in this issue, was caused by the 'is_running' key being defined inside of the
Boldgrid_Backup_Admin_Test::is_getpgid_supported()conditional. Therefor, systems that do not support getpgid, such as xampp. However, there is no reason that key should be dependant on that condition. Instead, it's been moved to be defined before the condition.You can test that this resolves the issue by going the the
is_getpgid_supportedmethod inadmin/class-boldgrid-backup-admin-test.phpand short circuiting the function with areturn false;statement, and running a backup.