Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

[Feature Request] - 1638 - Support for admonitions#1987

Merged
sosukesuzuki merged 1 commit into
BoostIO:masterfrom
johannbre:master
May 28, 2018
Merged

[Feature Request] - 1638 - Support for admonitions#1987
sosukesuzuki merged 1 commit into
BoostIO:masterfrom
johannbre:master

Conversation

@johannbre

Copy link
Copy Markdown
Contributor

Added support for markup admonitions by including markdown-it-admonition. Added material icon support and updates to styles for the rendering of six different types of admonitions.

admonitions

admonitions

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label May 27, 2018
@sosukesuzuki sosukesuzuki self-requested a review May 28, 2018 01:39

@sosukesuzuki sosukesuzuki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@sosukesuzuki sosukesuzuki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I noticed that you forgot running yarn after approved.
please commit yarn.lock.

@kazup01 kazup01 added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels May 28, 2018
Added support for markup admonitions by including markdown-it-admonition. Added material icon support and updates to styles for rendering of six different types of admonitions.
@johannbre

Copy link
Copy Markdown
Contributor Author

Committed and pushed

@sosukesuzuki sosukesuzuki merged commit 8e74ee7 into BoostIO:master May 28, 2018
@sosukesuzuki sosukesuzuki removed the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label May 28, 2018
@TobseF

TobseF commented Jun 15, 2018

Copy link
Copy Markdown

Doesn't work on Windows if the Material Icon font isn't installed.
#2083

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants